Skip to content

v2.5.0#66

Merged
notgull merged 1 commit into
masterfrom
notgull/next
Apr 26, 2024
Merged

v2.5.0#66
notgull merged 1 commit into
masterfrom
notgull/next

Conversation

@notgull
Copy link
Copy Markdown
Contributor

@notgull notgull commented Apr 5, 2024

@notgull notgull requested a review from taiki-e April 5, 2024 16:12
Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Copy link
Copy Markdown
Contributor Author

notgull commented Apr 14, 2024

Added #67 to this

@taiki-e
Copy link
Copy Markdown
Collaborator

taiki-e commented Apr 14, 2024

(I don't have time right now and will review the actual changes next weekend.)

@notgull
Copy link
Copy Markdown
Contributor Author

notgull commented Apr 14, 2024

Thank you @taiki-e! I appreciate your insight!

(I don't have time right now and will review the actual changes next weekend.)

Would replacing concurrent-queue's implementation with one based on crossbeam-queue be appreciated from this perspective? This way there's only one queue implementation to review.

cc #50

@taiki-e
Copy link
Copy Markdown
Collaborator

taiki-e commented Apr 22, 2024

(reviewed #58 (review))

Would replacing concurrent-queue's implementation with one based on crossbeam-queue be appreciated from this perspective? This way there's only one queue implementation to review.

Yeah, I would like to eventually merge them...

@notgull notgull merged commit e874f70 into master Apr 26, 2024
@notgull notgull deleted the notgull/next branch April 26, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants